Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

would be nice to have the ability to link to stylesheet #482

Closed
gdamore opened this issue Jan 23, 2020 · 6 comments · Fixed by #487
Closed

would be nice to have the ability to link to stylesheet #482

gdamore opened this issue Jan 23, 2020 · 6 comments · Fixed by #487
Assignees
@xcoulon
Labels
area/cli type/feature
Milestone
v0.3.0

Comments

@gdamore
Copy link
Collaborator

gdamore commented Jan 23, 2020

The generated document doesn't include any style sheet data at all. But my asciidoctor generated files do -- they either embed a whole style sheet, or link to it via ./asciidoctor.css -- they also in my case link to google font servers to pick up OpenSans.

Probably you don't want to include the stock style sheet, but it would be nice if we could specify either style sheet, or more "link" attributes to include in the meta section.

I can of course post-process the document and inject those myself, but it seems kind of dirty to do that.
@xcoulon
Copy link
Member

xcoulon commented Jan 23, 2020

sure, that's what I had in mind with #63, actually ;) I'll address that gap.

@xcoulon
Copy link
Member

xcoulon commented Jan 25, 2020 •
edited
Loading

Actually, I will keep #63 open to embed a CSS in the generated HTML documents, but in the mean time I can add a --css argument to the CLI so the HTML documents have a <link type="text/css" rel="stylesheet" href="<css_argument>"> their the <head> section. Would that work for you @gdamore?

xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jan 25, 2020
@xcoulon
feat(cli): add 'css' arg to specify the stylesheet
b20f398 
when the `--css=...` argument is used, the generated HTML
document contains a `<link type="text/html" rel="stylesheet" href="...">"
element with the given `--css` value.

Fixes bytesparadise#482

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Jan 25, 2020
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jan 25, 2020
@xcoulon
feat(cli): add 'css' arg to specify the stylesheet
2fb71ee 
when the `--css=...` argument is used, the generated HTML
document contains a `<link type="text/html" rel="stylesheet" href="...">`
element with the given `--css` value.

Fixes bytesparadise#482

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon self-assigned this Jan 25, 2020
@xcoulon xcoulon added this to the v0.3.0 milestone Jan 25, 2020
@gdamore
Copy link
Collaborator Author

gdamore commented Jan 26, 2020

Yes that would do the trick for me.

xcoulon added a commit that referenced this issue Jan 27, 2020
@xcoulon
feat(cli): add 'css' arg to specify the stylesheet (#487)
c1de2f2 
when the `--css=...` argument is used, the generated HTML
document contains a `<link type="text/html" rel="stylesheet" href="...">`
element with the given `--css` value.

Fixes #482

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon
Copy link
Member

xcoulon commented Jan 27, 2020

@gdamore please let me know if the PR addressed your issue, otherwise feel free to open it again ;)

@gdamore
Copy link
Collaborator Author

gdamore commented Jan 28, 2020

I haven't tested it, but casual inspection makes me think it will do so.

We're so close to having all the things I want from this package -- and then I can start throwing away the mess of shell scripts I have to preprocess docs, and post process output, and replace them with some very nice Go code that wraps around libasciidoc.

I think the only really significant thing remaining from my part is support for syntax highlighting. (I'd love a pygments compatible one, but I'm happy to see any one that I can style accordingly.)

@xcoulon
Copy link
Member

xcoulon commented Jan 28, 2020

I haven't tested it, but casual inspection makes me think it will do so.

We're so close to having all the things I want from this package -- and then I can start throwing away the mess of shell scripts I have to preprocess docs, and post process output, and replace them with some very nice Go code that wraps around libasciidoc.

I think the only really significant thing remaining from my part is support for syntax highlighting. (I'd love a pygments compatible one, but I'm happy to see any one that I can style accordingly.)

Thanks for your feedback @gdamore!
I'll address your request about syntax highlighting (#488) before #484 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/cli type/feature
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

feat(cli): add 'css' arg to specify the stylesheet xcoulon/libasciidoc
2 participants
@xcoulon @gdamore