Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

// comment does not function properly if right after title #481

Closed
gdamore opened this issue Jan 23, 2020 · 2 comments · Fixed by #486
Closed

// comment does not function properly if right after title #481

gdamore opened this issue Jan 23, 2020 · 2 comments · Fixed by #486
Assignees
@xcoulon
Labels
area/parser type/bug
Milestone
v0.3.0

Comments

@gdamore
Copy link
Collaborator

gdamore commented Jan 23, 2020

This is a difference in handling vs. asciidoctor

If I have

= Title
// Copyright blah blah blah
// more boilerplate

Then the // is taken as an author. If I insert a new line in front of the boilerplate, it's fine.

The main concern here is that this behavior differs from asciidoctor. I have a large body of documents that lacks that extra whitespace.
@xcoulon
Copy link
Member

xcoulon commented Jan 23, 2020

ok, thanks for reporting this issue @gdamore and you're right, the goal is to be as compatible with Asciidoctor as possible, so I will address that

@xcoulon xcoulon self-assigned this Jan 23, 2020
@xcoulon xcoulon added this to the v0.3.0 milestone Jan 23, 2020
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jan 25, 2020
@xcoulon
fix(parser): support comment between doc title and author
74d47a9 
support comments (single lines and blocks) before the author
and between the author and the revision

Fixes bytesparadise#481

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Jan 25, 2020
Merged
xcoulon added a commit that referenced this issue Jan 27, 2020
@xcoulon
fix(parser): support comment between doc title and author (#486)
46e85ae 
support comments (single lines and blocks) before the author
and between the author and the revision

Fixes #481

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon
Copy link
Member

xcoulon commented Jan 27, 2020

@gdamore please let me know if the PR addressed your concern, otherwise feel free to reopen this issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser type/bug
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

fix(parser): support comment between doc title and author xcoulon/libasciidoc
2 participants
@xcoulon @gdamore