Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing \n in code block #470

Closed
xcoulon opened this issue Jan 6, 2020 · 0 comments · Fixed by #472
Closed

Remove trailing \n in code block #470

xcoulon opened this issue Jan 6, 2020 · 0 comments · Fixed by #472
Assignees
@xcoulon
Labels
area/renderer type/bug
Milestone
v0.3.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Jan 6, 2020

For example, this content:

[source, c]
----
#include <ff.h>

----

should render as:

<div class="listingblock">
<div class="content">
<pre class="highlight"><code class="language-c" data-lang="c">#include &lt;ff.h&gt;</code></pre>
</div>
</div>
@xcoulon xcoulon self-assigned this Jan 6, 2020
@xcoulon xcoulon added this to the v0.3.0 milestone Jan 6, 2020
@xcoulon xcoulon mentioned this issue Jan 6, 2020
Closed
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jan 7, 2020
@xcoulon
fix(parser/renderer): skip trailing empty lines in delimited blocks
cc65080 
change the parser rules to identify the blank lines and skip them
during rendering when there is nothing else afterwards

fixes bytesparadise#470

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Jan 7, 2020
Merged
xcoulon added a commit that referenced this issue Jan 7, 2020
@xcoulon
fix(parser/renderer): skip trailing empty lines in delimited blocks (#…
940da7f 
…472)

change the parser rules to identify the blank lines and skip them
during rendering when there is nothing else afterwards

fixes #470

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/renderer type/bug
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

fix(parser/renderer): skip trailing empty lines in delimited blocks xcoulon/libasciidoc
1 participant
@xcoulon