Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not retain SingleLineComments and CommentBlocks in final Document #454

Closed
xcoulon opened this issue Dec 26, 2019 · 0 comments · Fixed by #458
Closed

Do not retain SingleLineComments and CommentBlocks in final Document #454

xcoulon opened this issue Dec 26, 2019 · 0 comments · Fixed by #458
Assignees
@xcoulon
Labels
area/parser type/refactor
Milestone
v0.3.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Dec 26, 2019

SingleLineComment and CommentBlock should be part of the DraftDocument, but there is no need for keeping them in the final Document which is returned by the parser and passed to the renderer.
@xcoulon xcoulon added this to the v0.3.0 milestone Dec 26, 2019
@xcoulon xcoulon self-assigned this Dec 28, 2019
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jan 2, 2020
@xcoulon
refactor(parser):
dc5a36f 
Do not retain SingleLineComments and CommentBlocks in final Document

Refactor document processing to filter out all unneeded
blocks in the final document, including single line comments
and comment blocks

also, split the `document_processing.go` file for better
readability and testing

also, increase testing on quoted texts and lists

also, fix a problem where paragraph with empty content was
not rendered at all

fixes bytesparadise#454

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Jan 2, 2020
Merged
xcoulon added a commit that referenced this issue Jan 2, 2020
@xcoulon
refactor(parser): do not retain SingleLineComments and CommentBlocks …
2a13488 
…in final Document

Refactor document processing to filter out all unneeded
blocks in the final document, including single line comments
and comment blocks

also:
- split the `document_processing.go` file for better
readability and testing
- increase testing on quoted texts and lists
- fix a problem where paragraph with empty content was
not rendered at all

fixes #454

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser type/refactor
Projects
None yet
Milestone
v0.3.0
1 participant
@xcoulon