Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nested file inclusions with relative leveloffset #434

Closed
xcoulon opened this issue Nov 8, 2019 · 0 comments · Fixed by #437
Closed

Support nested file inclusions with relative leveloffset #434

xcoulon opened this issue Nov 8, 2019 · 0 comments · Fixed by #437
Assignees
@xcoulon
Labels
area/parser type/feature
Milestone
v0.3.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Nov 8, 2019 •
edited
Loading

Follow-up of #311, when a file to include also includes itself one or more files, with a relavite leveloffset attribute configured in the top-level inclusion macro.

Eg:

include::../test/includes/parent-include.adoc[leveloffset=+1]

which includes

= parent title

first line of parent

include::child-include.adoc[]

last line of parent

etc..

Also, handle the case where there's an include::child-include.adoc[leveloffset=+1]
@xcoulon xcoulon added this to the v0.3.0 milestone Nov 8, 2019
@xcoulon xcoulon self-assigned this Nov 8, 2019
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Nov 10, 2019
@xcoulon
feat(parser): support nested relative level offset in file inclusions
1943db7 
Uses a func type to proceed with the cumulated level offsets,
which should pave the road to support absolute level offsets, too.

Fixes bytesparadise#434

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Nov 10, 2019
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Nov 10, 2019
@xcoulon
feat(parser): support nested relative level offset in file inclusions
1edec7f 
Uses a func type to proceed with the cumulated level offsets,
which should pave the road to support absolute level offsets, too.

Fixes bytesparadise#434

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Nov 10, 2019
@xcoulon
feat(parser): support nested relative level offset in file inclusions (…
2bb6f9d 
…#437)

Uses a func type to proceed with the cumulated level offsets,
which should pave the road to support absolute level offsets, too.

Fixes #434

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser type/feature
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

feat(parser): support nested relative level offset in file inclusions xcoulon/libasciidoc
1 participant
@xcoulon