Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reporting in custom matchers #421

Closed
xcoulon opened this issue Sep 29, 2019 · 0 comments · Fixed by #422
Closed

Improve reporting in custom matchers #421

xcoulon opened this issue Sep 29, 2019 · 0 comments · Fixed by #422
Assignees
@xcoulon
Labels
area/test type/refactor
Milestone
v0.3.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Sep 29, 2019

Improve the reporting of the custom Gomega matches introduced in #412 so it's easier to understand when the actual and expected values differ.
@xcoulon xcoulon self-assigned this Sep 29, 2019
@xcoulon xcoulon added this to the v0.3.0 milestone Sep 29, 2019
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 29, 2019
@xcoulon
refactor(test): improve failure messages in custom matchers
7b6e948 
display a readable diff of the "processed actual" vs "expected"
values

Fixes bytesparadise#421

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Sep 29, 2019
Merged
xcoulon added a commit that referenced this issue Sep 30, 2019
@xcoulon
refactor(test): improve failure messages in custom matchers (#422)
37e48f8 
display a readable diff of the "processed actual" vs "expected"
values

Fixes #421

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/test type/refactor
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

refactor(test): improve failure messages in custom matchers xcoulon/libasciidoc
1 participant
@xcoulon