fix(parser): support commas in link text attribute #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supoort text with comma and without being surrounded by double quotes if no other attribute is defined, or require the (positional) text attribute to be surrounded with double quotes if it contains commas and there are other attributes in the link macro. fixes bytesparadise#388 Signed-off-by: Xavier Coulon <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 48 48
Lines 4297 4297
=======================================
Hits 3501 3501
Misses 659 659
Partials 137 137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supoort text with comma and without being surrounded
by double quotes if no other attribute is defined,
or require the (positional) text attribute to be
surrounded with double quotes if it contains commas
and there are other attributes in the link macro.
fixes #388
Signed-off-by: Xavier Coulon [email protected]