Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comma inside link's description clear the rest of characters #388

Closed
shuLhan opened this issue Aug 28, 2019 · 2 comments · Fixed by #389
Closed

Comma inside link's description clear the rest of characters #388

shuLhan opened this issue Aug 28, 2019 · 2 comments · Fixed by #389
Labels
area/parser area/renderer type/bug
Milestone
v0.3.0

Comments

@shuLhan
Copy link
Contributor

shuLhan commented Aug 28, 2019

Hi @xcoulon ,

I would like to report some issue again with text inside link description. This is tested on master branch on commit 5321fe2.

== Environments

libasciidoc v0.2.1-0.20190826055451-5321fe2e765e

== Input

link:/[A, B, and C]

== Actual Output

<a href="/">A</a>

== Expected Output

<a href="/">A, B, and C</a>

I am sorry, I can't help with code, only reporting issues :/
@xcoulon
Copy link
Member

xcoulon commented Aug 29, 2019

@shuLhan thanks for reporting this issue, I'll look into it.

I am sorry, I can't help with code, only reporting issues :/

reporting is already helping ;)

@xcoulon xcoulon added this to the v0.3.0 milestone Aug 29, 2019
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Aug 31, 2019
@xcoulon
fix(parser): support commas in link text attribute
9ff74cd 
supoort text with comma and without being surrounded
by double quotes if no other attribute is defined,
or require the (positional) text attribute to be
surrounded with double quotes if it contains commas
and there are other attributes in the link macro.

fixes bytesparadise#388

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Aug 31, 2019
Merged
xcoulon added a commit that referenced this issue Aug 31, 2019
@xcoulon
fix(parser): support commas in link text attribute (#389)
23feea9 
supoort text with comma and without being surrounded
by double quotes if no other attribute is defined,
or require the (positional) text attribute to be
surrounded with double quotes if it contains commas
and there are other attributes in the link macro.

fixes #388

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Aug 31, 2019
@xcoulon
refactor(renderer): rename files and add tests
6868a9b 
updates bytesparadise#388

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Aug 31, 2019
@xcoulon
refactor(renderer): rename files and add tests
b0f6b64 
updates bytesparadise#388

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Aug 31, 2019
Merged
@xcoulon
Copy link
Member

xcoulon commented Aug 31, 2019

@shuLhan this should be fixed in master. Please let me know if it works for you now

xcoulon added a commit that referenced this issue Aug 31, 2019
@xcoulon
refactor(renderer): rename files and add tests (#390)
c872c70 
updates #388

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/parser area/renderer type/bug
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

fix(parser): support commas in link text attribute xcoulon/libasciidoc
2 participants
@shuLhan @xcoulon