Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide actual filename in file inclusion error message #384

Closed
xcoulon opened this issue Aug 25, 2019 · 0 comments · Fixed by #402
Closed

Provide actual filename in file inclusion error message #384

xcoulon opened this issue Aug 25, 2019 · 0 comments · Fixed by #402
Assignees
@xcoulon
Labels
area/parser type/bug
Milestone
v0.3.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Aug 25, 2019

The current message refers to test.adoc (see https://github.com/bytesparadise/libasciidoc/blob/master/pkg/parser/document_preprocessing.go#L94)
@xcoulon xcoulon added this to the v0.3.0 milestone Aug 25, 2019
@xcoulon xcoulon self-assigned this Sep 8, 2019
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 8, 2019
@xcoulon
fix(parser): provide actual filename in file inclusion error msg
87f0b24 
Fixes bytesparadise#384

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Sep 8, 2019
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 8, 2019
@xcoulon
fix(parser): provide actual filename in file inclusion error msg
4795dfa 
Fixes bytesparadise#384

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Sep 9, 2019
@xcoulon
fix(parser): provide actual filename in file inclusion error msg (#402)
bc3d557 
Fixes #384

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser type/bug
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

fix(parser): provide actual filename in file inclusion error msg xcoulon/libasciidoc
1 participant
@xcoulon