Refactor file inclusions #343
Comments
xcoulon
added a commit
to xcoulon/libasciidoc
that referenced
this issue
May 5, 2019
add a new entrypoint in the grammar to "preparse" the document, only looking for a subset of elements, in particular the `include` directives and the sections whose level may be offset during the file inclusions. Once the file have been included (ie, the `include` directives have been replaced with the actual file content), then the document can be fully parsed. Fixes bytesparadise#343 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
added a commit
to xcoulon/libasciidoc
that referenced
this issue
May 7, 2019
add a new entrypoint in the grammar to "preparse" the document, only looking for a subset of elements, in particular the `include` directives and the sections whose level may be offset during the file inclusions. Once the file have been included (ie, the `include` directives have been replaced with the actual file content), then the document can be fully parsed. Fixes bytesparadise#343 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
added a commit
to xcoulon/libasciidoc
that referenced
this issue
May 7, 2019
add a new entrypoint in the grammar to "preparse" the document, only looking for a subset of elements, in particular the `include` directives and the sections whose level may be offset during the file inclusions. Once the file have been included (ie, the `include` directives have been replaced with the actual file content), then the document can be fully parsed. Fixes bytesparadise#343 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
added a commit
that referenced
this issue
May 8, 2019
add a new entrypoint in the grammar to "preparse" the document, only looking for a subset of elements, in particular the `include` directives and the sections whose level may be offset during the file inclusions. Once the file have been included (ie, the `include` directives have been replaced with the actual file content), then the document can be fully parsed. Fixes #343 Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current logic to process the file inclusions should be rewritten: including the files during the
renderphase causes troubles all existing elements after the included ones need to be reprocessed (see #332)Instead, the file inclusions should be executed during a
preparsephase, where the raw content is added into the "master" document, which can then be parsed in a single shot.The text was updated successfully, but these errors were encountered: