Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for explicit line breaks #189

Closed
pjanx opened this issue Sep 24, 2018 · 2 comments · Fixed by #195
Closed

Support for explicit line breaks #189

pjanx opened this issue Sep 24, 2018 · 2 comments · Fixed by #195
Labels
area/parser area/renderer type/feature
Milestone
v0.1.0

Comments

@pjanx
Copy link
Contributor

pjanx commented Sep 24, 2018

http://www.methods.co.nz/asciidoc/asciidoc.html#_line_breaks

abc +
def

should produce

<p>abc<br>def</p>
@pjanx pjanx changed the title Support explicit line breaks Support for explicit line breaks Sep 24, 2018
@xcoulon
Copy link
Member

xcoulon commented Sep 24, 2018

thanks for reporting this issue, @pjanx! I'll take care of it

xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Oct 6, 2018
@xcoulon
feat(parser/renderer): support explicit line breaks
4c18c43 
supported with the ` +` suffix in paragraph lines,
and the `[%hardbreaks] attribute on a paragraph.

fixes bytesparadise#189

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Oct 6, 2018
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Oct 6, 2018
@xcoulon
feat(parser/renderer): support explicit line breaks
3c123ed 
supported with the ` +` suffix in paragraph lines,
and the `[%hardbreaks] attribute on a paragraph.

also, refactoring in the renderer to remove some
functions that can be replaced with native templates
functions, and simplify others.

fixes bytesparadise#189

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Oct 6, 2018
@xcoulon
feat(parser/renderer): support explicit line breaks
b1ccebb 
supported with the ` +` suffix in paragraph lines,
with the `[%hardbreaks] attribute on a paragraph and
with the `:hardbreaks:` attribute at the document level.

also, refactoring in the renderer to remove some
functions that can be replaced with native templates
functions, and simplify others.

fixes bytesparadise#189

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Oct 6, 2018
@xcoulon
feat(parser/renderer): support explicit line breaks (#195)
f5f87cc 
supported with the ` +` suffix in paragraph lines,
with the `[%hardbreaks] attribute on a paragraph and
with the `:hardbreaks:` attribute at the document level.

also, refactoring in the renderer to remove some
functions that can be replaced with native templates
functions, and simplify others.

fixes #189

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon
Copy link
Member

xcoulon commented Oct 6, 2018

@pjanx issue should be fixed now. Thanks again for reporting it, and feel free to reopen if you find anything wrong with regards to hard breaks ;)

@xcoulon xcoulon added this to the v0.1 milestone Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/parser area/renderer type/feature
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

feat(parser/renderer): support explicit line breaks xcoulon/libasciidoc
2 participants
@xcoulon @pjanx