refactor(parser): do not reparse image 'alt' attribute

only apply attribute substitutions Signed-off-by: Xavier Coulon <[email protected]>
bytesparadise · May 16, 2022 · 13c98b7 · 13c98b7
1 parent 8c2d04a
commit 13c98b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 27 deletions.
diff --git a/pkg/parser/document_processing_apply_substitutions.go b/pkg/parser/document_processing_apply_substitutions.go
@@ -504,7 +504,7 @@ func reparseAttributes(e types.WithAttributes, subs []string, opts ...Option) er
 	}
 	for k, v := range attributes {
 		switch k {
-		case types.AttrTitle, types.AttrXRefLabel, types.AttrInlineLinkText, types.AttrImageAlt:
+		case types.AttrTitle, types.AttrXRefLabel, types.AttrInlineLinkText:
 			v, err := ReparseAttributeValue(v, subs, opts...)
 			if err != nil {
 				return err

diff --git a/pkg/parser/document_processing_apply_substitutions_test.go b/pkg/parser/document_processing_apply_substitutions_test.go
@@ -333,19 +333,7 @@ var _ = Describe("apply substitutions", func() {
 					Elements: []interface{}{
 						&types.InlineImage{
 							Attributes: types.Attributes{
-								types.AttrImageAlt: []interface{}{
-									&types.QuotedText{
-										Kind: types.SingleQuoteItalic,
-										Attributes: types.Attributes{
-											types.AttrRoles: types.Roles{"role_1"},
-										},
-										Elements: []interface{}{
-											&types.StringElement{
-												Content: "yummy!",
-											},
-										},
-									},
-								},
+								types.AttrImageAlt: "[.role_1]_yummy!_",
 							},
 							Location: &types.Location{
 								Path: "yummy.png",
@@ -505,19 +493,7 @@ var _ = Describe("apply substitutions", func() {
 											Elements: []interface{}{
 												&types.InlineImage{
 													Attributes: types.Attributes{
-														types.AttrImageAlt: []interface{}{
-															&types.QuotedText{
-																Kind: types.SingleQuoteItalic,
-																Attributes: types.Attributes{
-																	types.AttrRoles: types.Roles{"role_1"},
-																},
-																Elements: []interface{}{
-																	&types.StringElement{
-																		Content: "yummy row!",
-																	},
-																},
-															},
-														},
+														types.AttrImageAlt: "[.role_1]_yummy row!_",
 													},
 													Location: &types.Location{
 														Path: "yummy.png",