Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function which return a falsy javascript value cause a promise rejection #20

Closed
thebongy opened this issue May 8, 2020 · 0 comments
Closed

Function which return a falsy javascript value cause a promise rejection #20

thebongy opened this issue May 8, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@thebongy
Copy link
Contributor

thebongy commented May 8, 2020

Using module.callFunction on a function that doesn't return back a value, or returns back a falsy value, like false, or null, leads to a promise rejection, instead of properly propagating the response of the function
@thebongy thebongy added the bug Something isn't working label May 8, 2020
thebongy added a commit that referenced this issue May 8, 2020
@thebongy
Support Juno Error Codes and returning falsy values from functions (#21)
31f6e4a 
* fix: Throw unkown function error code when function not found in module.
Support returning falsy values from a juno function

* Bump version to 0.1.2

* feat: Include juno error message on errors
Closes #20 and Closes #19
@thebongy thebongy closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thebongy