Human-readable serde impl loses precision, serializes bytes incorrectly

[sunshowers]

Hi there, thanks for the crate!

While developing against the crate I found that human-readable serde impl's serializer is incorrect. For example, the following program:

use bytesize::ByteSize;

fn main() {
    let json = serde_json::to_string(&ByteSize::mib(1)).unwrap();
    println!("serialized JSON: {json}");

    let deserialized: ByteSize = serde_json::from_str(&json).unwrap();
    println!("deserialized: {}", deserialized.0);
}

prints out:

serialized JSON: "1048.6 KB"
deserialized: 1048600

Which means that serialization/deserialization does not roundtrip.

I think serialization should either be to an integer, or to exact values (e.g. "1048.576 KB"). What do you think?

[MrCroxx]

Hi @sunshowers . Thanks for reporting. This was caused by the 1.x uses SI units. With 2.0 (unreleased, I'm going to push the process to release it after introducing some features), bytesize uses IEC units, which would make things clearer for programmers.