Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for name duplicates in containers #741

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Check for name duplicates in containers #741

merged 3 commits into from
Jan 31, 2024

Conversation

HGuillemet
Copy link
Contributor

Sometimes we add duplicate names in Info.pointerTypes or javaNames to ensure that the proper method overloads are generated (see #740).

When a function is parsed, resulting Java declarations with same signature are deduplicated, but not when containers are generated.

This PR add checks to prevent duplicate generation of container constructors and methods in these cases.

saudet
saudet approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@saudet saudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any else to add and/or check? Or is this good to merge?

@HGuillemet
Copy link
Contributor Author

Good to merge.

@saudet saudet merged commit 80d0828 into bytedeco:master Jan 31, 2024
11 checks passed
@HGuillemet HGuillemet deleted the containers_dedup branch January 31, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saudet saudet saudet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HGuillemet @saudet