-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/test: t.Fatal should be called from g
running the test or benchmark func
#505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the orignal code is not formatted as go conventions.
Too many changes ... I will submit a small CL, instead. |
Thanks. Lots of changes now, welcome to submit a small CL ~ |
for format, sonic has its own style. If you want to change, you need change all the go files... |
… func The linter complains: the goroutine calls T.Fatal, which must be called in the same goroutine as the testSA2002(default). testing.T.Fail will calls testing.common.FailNow(), this function will marks the test failing and call runtime.GoExit(). Sure, it could let the calling goroutine exit, but this is a misuse. t.Fail should be used for marks the test failing and let the goroutine which runs this test or the benchmark func exit. So, just use t.Error+return instead.
I have submit a small CL, without changing the format style. |
liuq19
approved these changes
Aug 22, 2023
Thanks, LGTM |
kodiakhq bot
referenced
this pull request
in cloudquery/plugin-pb-go
Oct 1, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/bytedance/sonic](https://togithub.com/bytedance/sonic) | indirect | patch | `v1.10.0-rc` -> `v1.10.1` | --- ### Release Notes <details> <summary>bytedance/sonic (github.com/bytedance/sonic)</summary> ### [`v1.10.1`](https://togithub.com/bytedance/sonic/releases/tag/v1.10.1) [Compare Source](https://togithub.com/bytedance/sonic/compare/v1.10.0...v1.10.1) #### Feature - \[[#​511](https://togithub.com/bytedance/sonic/issues/511)] (ast) support sort keys on non-object node - \[[#​527](https://togithub.com/bytedance/sonic/issues/527)] (encoder) Add `NoValidateJSONMarshaler` option #### Bugfix - \[[#​504](https://togithub.com/bytedance/sonic/issues/504)] (ast) check error before `Set/Unset/Add()` - \[[#​520](https://togithub.com/bytedance/sonic/issues/520)] (native) over boundary bugs of skip number and tolower in native c #### New Contributors - [@​jimyag](https://togithub.com/jimyag) made their first contribution in [https://github.com/bytedance/sonic/pull/501](https://togithub.com/bytedance/sonic/pull/501) - [@​hitzhangjie](https://togithub.com/hitzhangjie) made their first contribution in [https://github.com/bytedance/sonic/pull/505](https://togithub.com/bytedance/sonic/pull/505) - [@​xiezheng-XD](https://togithub.com/xiezheng-XD) made their first contribution in [https://github.com/bytedance/sonic/pull/516](https://togithub.com/bytedance/sonic/pull/516) - [@​andeya](https://togithub.com/andeya) made their first contribution in [https://github.com/bytedance/sonic/pull/527](https://togithub.com/bytedance/sonic/pull/527) **Full Changelog**: bytedance/sonic@v1.10.0...v1.10.1 ### [`v1.10.0`](https://togithub.com/bytedance/sonic/releases/tag/v1.10.0) [Compare Source](https://togithub.com/bytedance/sonic/compare/v1.10.0-rc3...v1.10.0) #### Feature - \[[#​493](https://togithub.com/bytedance/sonic/issues/493)] **support Go1.21.0** - \[[#​471](https://togithub.com/bytedance/sonic/issues/471)] (ast) add `ast.Visitor` for transversing JSON in-place - \[[#​470](https://togithub.com/bytedance/sonic/issues/470)] add `Valid()` API #### Bugfix - \[[#​486](https://togithub.com/bytedance/sonic/issues/486)] possible overflowed instruction while handling `byte` type - \[[#​484](https://togithub.com/bytedance/sonic/issues/484)] (decoder) avoid scratched memory of returned error - \[[#​496](https://togithub.com/bytedance/sonic/issues/496)] (ast) Exist() didn't check Valid() first - \[[#​498](https://togithub.com/bytedance/sonic/issues/498)] (ast) drop ast.Node API `UnsafeArray()` and `UnsafeMap()` (**Break Change**) #### Optimization - \[[#​393](https://togithub.com/bytedance/sonic/issues/393)] **refactor `asm2asm` to avoid `SIGPROF` crashing, and enable traceback when C function panics** - \[[#​464](https://togithub.com/bytedance/sonic/issues/464)] (ast) use linked chunk as fundamental storage for nodes to keep node pointer valid (**Break Change**) - \[[#​464](https://togithub.com/bytedance/sonic/issues/464)] (ast) avoid malloc when meeting empty values, and inline header chunk into lazy-parsing stack to reduce malloc. **The performance of `Parse()\Load()\Interface()` promoted 10~60%** - \[[#​475](https://togithub.com/bytedance/sonic/issues/475)] (last) pass `skipnumber` flag to avoid decoding numbers #### New Contributors - [@​xumingyukou](https://togithub.com/xumingyukou) made their first contribution in [https://github.com/bytedance/sonic/pull/447](https://togithub.com/bytedance/sonic/pull/447) - [@​zhongxinghong](https://togithub.com/zhongxinghong) made their first contribution in [https://github.com/bytedance/sonic/pull/471](https://togithub.com/bytedance/sonic/pull/471) **Full Changelog**: bytedance/sonic@v1.9.2...v1.10.0 ### [`v1.10.0-rc3`](https://togithub.com/bytedance/sonic/compare/v1.10.0-rc2...v1.10.0-rc3) [Compare Source](https://togithub.com/bytedance/sonic/compare/v1.10.0-rc2...v1.10.0-rc3) ### [`v1.10.0-rc2`](https://togithub.com/bytedance/sonic/releases/tag/v1.10.0-rc2) [Compare Source](https://togithub.com/bytedance/sonic/compare/v1.10.0-rc...v1.10.0-rc2) #### Optimization - \[[#​475](https://togithub.com/bytedance/sonic/issues/475)] (ast) pass `skipnumber` flag to avoid decoding numbers - \[[#​483](https://togithub.com/bytedance/sonic/issues/483)] update base64x to finish asm2asm refactor #### Feature - \[[#​471](https://togithub.com/bytedance/sonic/issues/471)] (ast) add `ast.Visitor` for iterating JSON into custom generic data containers in-place #### New Contributors - [@​zhongxinghong](https://togithub.com/zhongxinghong) made their first contribution in [https://github.com/bytedance/sonic/pull/471](https://togithub.com/bytedance/sonic/pull/471) **Full Changelog**: bytedance/sonic@v1.10.0-rc...v1.10.0-rc2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter complains: the goroutine calls T.Fatal, which must be called in the same goroutine as the testSA2002(default).
testing.T.Fail will calls testing.common.FailNow(), this function will marks the test failing and call runtime.GoExit(). Sure, it could let the calling goroutine exit, but this is a misuse.
t.Fail should be used for marks the test failing and let the goroutine which runs this test or the benchmark func exit. So, just use t.Error+return instead.