Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/test: t.Fatal should be called from g running the test or benchmark func #505

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

hitzhangjie
Copy link
Contributor

The linter complains: the goroutine calls T.Fatal, which must be called in the same goroutine as the testSA2002(default).

testing.T.Fail will calls testing.common.FailNow(), this function will marks the test failing and call runtime.GoExit(). Sure, it could let the calling goroutine exit, but this is a misuse.

t.Fail should be used for marks the test failing and let the goroutine which runs this test or the benchmark func exit. So, just use t.Error+return instead.

@hitzhangjie
Copy link
Contributor Author

hitzhangjie commented Aug 16, 2023

It looks like the orignal code is not formatted as go conventions.

  1. use 4 spaces -> uses 1 tab;
  2. import uses `importPath` -> go uses "importPath"

Too many changes ... I will submit a small CL, instead.

@liuq19
Copy link
Collaborator

liuq19 commented Aug 16, 2023

Thanks. Lots of changes now, welcome to submit a small CL ~

@AsterDY
Copy link
Collaborator

AsterDY commented Aug 21, 2023

for format, sonic has its own style. If you want to change, you need change all the go files...

… func

The linter complains: the goroutine calls T.Fatal, which must be called in the
same goroutine as the testSA2002(default).

testing.T.Fail will calls testing.common.FailNow(), this function will marks
the test failing and call runtime.GoExit(). Sure, it could let the calling
goroutine exit, but this is a misuse.

t.Fail should be used for marks the test failing and let the goroutine which
runs this test or the benchmark func exit. So, just use t.Error+return instead.
@hitzhangjie
Copy link
Contributor Author

I have submit a small CL, without changing the format style.

@liuq19
Copy link
Collaborator

liuq19 commented Aug 22, 2023

Thanks, LGTM

@liuq19 liuq19 merged commit 32e0d6a into bytedance:main Aug 22, 2023
23 checks passed
kodiakhq bot referenced this pull request in cloudquery/plugin-pb-go Oct 1, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/bytedance/sonic](https://togithub.com/bytedance/sonic) | indirect | patch | `v1.10.0-rc` -> `v1.10.1` |

---

### Release Notes

<details>
<summary>bytedance/sonic (github.com/bytedance/sonic)</summary>

### [`v1.10.1`](https://togithub.com/bytedance/sonic/releases/tag/v1.10.1)

[Compare Source](https://togithub.com/bytedance/sonic/compare/v1.10.0...v1.10.1)

#### Feature

-   \[[#&#8203;511](https://togithub.com/bytedance/sonic/issues/511)] (ast) support sort keys on non-object node
-   \[[#&#8203;527](https://togithub.com/bytedance/sonic/issues/527)] (encoder) Add `NoValidateJSONMarshaler` option

#### Bugfix

-   \[[#&#8203;504](https://togithub.com/bytedance/sonic/issues/504)] (ast) check error before `Set/Unset/Add()`
-   \[[#&#8203;520](https://togithub.com/bytedance/sonic/issues/520)] (native) over boundary bugs of skip number and tolower in native c

#### New Contributors

-   [@&#8203;jimyag](https://togithub.com/jimyag) made their first contribution in [https://github.com/bytedance/sonic/pull/501](https://togithub.com/bytedance/sonic/pull/501)
-   [@&#8203;hitzhangjie](https://togithub.com/hitzhangjie) made their first contribution in [https://github.com/bytedance/sonic/pull/505](https://togithub.com/bytedance/sonic/pull/505)
-   [@&#8203;xiezheng-XD](https://togithub.com/xiezheng-XD) made their first contribution in [https://github.com/bytedance/sonic/pull/516](https://togithub.com/bytedance/sonic/pull/516)
-   [@&#8203;andeya](https://togithub.com/andeya) made their first contribution in [https://github.com/bytedance/sonic/pull/527](https://togithub.com/bytedance/sonic/pull/527)

**Full Changelog**: bytedance/sonic@v1.10.0...v1.10.1

### [`v1.10.0`](https://togithub.com/bytedance/sonic/releases/tag/v1.10.0)

[Compare Source](https://togithub.com/bytedance/sonic/compare/v1.10.0-rc3...v1.10.0)

#### Feature

-   \[[#&#8203;493](https://togithub.com/bytedance/sonic/issues/493)] **support Go1.21.0**
-   \[[#&#8203;471](https://togithub.com/bytedance/sonic/issues/471)] (ast) add `ast.Visitor` for transversing JSON in-place
-   \[[#&#8203;470](https://togithub.com/bytedance/sonic/issues/470)] add `Valid()` API

#### Bugfix

-   \[[#&#8203;486](https://togithub.com/bytedance/sonic/issues/486)] possible overflowed instruction while handling `byte` type
-   \[[#&#8203;484](https://togithub.com/bytedance/sonic/issues/484)] (decoder) avoid scratched memory of returned error
-   \[[#&#8203;496](https://togithub.com/bytedance/sonic/issues/496)] (ast) Exist() didn't check Valid() first
-   \[[#&#8203;498](https://togithub.com/bytedance/sonic/issues/498)] (ast) drop ast.Node API `UnsafeArray()` and `UnsafeMap()` (**Break Change**)

#### Optimization

-   \[[#&#8203;393](https://togithub.com/bytedance/sonic/issues/393)] **refactor `asm2asm` to avoid `SIGPROF` crashing, and enable traceback when C function panics**
-   \[[#&#8203;464](https://togithub.com/bytedance/sonic/issues/464)] (ast) use linked chunk as fundamental storage for nodes to keep node pointer valid (**Break Change**)
-   \[[#&#8203;464](https://togithub.com/bytedance/sonic/issues/464)] (ast) avoid malloc when meeting empty values, and inline header chunk into lazy-parsing stack to reduce malloc. **The performance of `Parse()\Load()\Interface()` promoted 10~60%**
-   \[[#&#8203;475](https://togithub.com/bytedance/sonic/issues/475)] (last) pass `skipnumber` flag to avoid decoding numbers

#### New Contributors

-   [@&#8203;xumingyukou](https://togithub.com/xumingyukou) made their first contribution in [https://github.com/bytedance/sonic/pull/447](https://togithub.com/bytedance/sonic/pull/447)
-   [@&#8203;zhongxinghong](https://togithub.com/zhongxinghong) made their first contribution in [https://github.com/bytedance/sonic/pull/471](https://togithub.com/bytedance/sonic/pull/471)

**Full Changelog**: bytedance/sonic@v1.9.2...v1.10.0

### [`v1.10.0-rc3`](https://togithub.com/bytedance/sonic/compare/v1.10.0-rc2...v1.10.0-rc3)

[Compare Source](https://togithub.com/bytedance/sonic/compare/v1.10.0-rc2...v1.10.0-rc3)

### [`v1.10.0-rc2`](https://togithub.com/bytedance/sonic/releases/tag/v1.10.0-rc2)

[Compare Source](https://togithub.com/bytedance/sonic/compare/v1.10.0-rc...v1.10.0-rc2)

#### Optimization

-   \[[#&#8203;475](https://togithub.com/bytedance/sonic/issues/475)] (ast) pass `skipnumber` flag to avoid decoding numbers
-   \[[#&#8203;483](https://togithub.com/bytedance/sonic/issues/483)] update base64x to finish asm2asm refactor

#### Feature

-   \[[#&#8203;471](https://togithub.com/bytedance/sonic/issues/471)] (ast) add `ast.Visitor` for iterating JSON into custom generic data containers in-place

#### New Contributors

-   [@&#8203;zhongxinghong](https://togithub.com/zhongxinghong) made their first contribution in [https://github.com/bytedance/sonic/pull/471](https://togithub.com/bytedance/sonic/pull/471)

**Full Changelog**: bytedance/sonic@v1.10.0-rc...v1.10.0-rc2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
@hitzhangjie hitzhangjie deleted the fix/test branch October 10, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants