Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible wrong instruction about _T_byte #486

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: possible wrong instruction about _T_byte #486

merged 1 commit into from
Jul 26, 2023

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Jul 26, 2023

_T_byte may be a large imm64, such as '0x8001d21b00', which will cause illegal x86 instruction

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@1c430d4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 615a0d5 differs from pull request most recent head a8b8819. Consider uploading reports for the commit a8b8819 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage        ?   77.93%           
=======================================
  Files           ?       63           
  Lines           ?    10567           
  Branches        ?        0           
=======================================
  Hits            ?     8235           
  Misses          ?     1971           
  Partials        ?      361           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liuq19 liuq19 marked this pull request as ready for review July 26, 2023 08:03
@liuq19 liuq19 changed the title fix: possible wrong instruction fix: possible wrong instruction about _T_byte Jul 26, 2023
@liuq19 liuq19 merged commit 7f66420 into main Jul 26, 2023
18 checks passed
@liuq19 liuq19 deleted the fix/instr branch July 26, 2023 08:46
imgbot bot pushed a commit to sarvex/bytedance-sonic that referenced this pull request Jul 30, 2023
imgbot bot pushed a commit to sarvex/bytedance-sonic that referenced this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants