Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulley: Implement lowering for stack_addr #9661

Merged
merged 1 commit into from
Nov 22, 2024
Merged

pulley: Implement lowering for stack_addr #9661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cranelift/codegen/src/isa/pulley_shared/lower.isle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,3 +230,14 @@
src
ty
flags)))

;;;; Rules for `stack_addr` ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

(rule (lower (stack_addr stack_slot offset))
(lower_stack_addr stack_slot offset))

(decl lower_stack_addr (StackSlot Offset32) XReg)
(rule (lower_stack_addr stack_slot offset)
(let ((dst WritableXReg (temp_writable_xreg))
(_ Unit (emit (abi_stackslot_addr dst stack_slot offset))))
dst))
45 changes: 45 additions & 0 deletions cranelift/filetests/filetests/isa/pulley32/stack_addr.clif
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
test compile precise-output
target pulley32

function %ret_stack() -> i32 {
ss0 = explicit_slot 4
block0():
v0 = stack_addr.i32 ss0
return v0
}

; VCode:
; x30 = xconst8 -16
; x27 = xadd32 x27, x30
; store64 sp+8, x28 // flags = notrap aligned
; store64 sp+0, x29 // flags = notrap aligned
; x29 = xmov x27
; x30 = xconst8 -16
; x27 = xadd32 x27, x30
; block0:
; x0 = load_addr Slot(0)
; x30 = xconst8 16
; x27 = xadd32 x27, x30
; x28 = load64_u sp+8 // flags = notrap aligned
; x29 = load64_u sp+0 // flags = notrap aligned
; x30 = xconst8 16
; x27 = xadd32 x27, x30
; ret
;
; Disassembled:
; 0: 14 1e f0 xconst8 spilltmp0, -16
; 3: 18 7b 7b xadd32 sp, sp, spilltmp0
; 6: 32 1b 08 1c store64_offset8 sp, 8, lr
; a: 30 1b 1d store64 sp, fp
; d: 11 1d 1b xmov fp, sp
; 10: 14 1e f0 xconst8 spilltmp0, -16
; 13: 18 7b 7b xadd32 sp, sp, spilltmp0
; 16: 11 00 1b xmov x0, sp
; 19: 14 1e 10 xconst8 spilltmp0, 16
; 1c: 18 7b 7b xadd32 sp, sp, spilltmp0
; 1f: 2b 1c 1b 08 load64_offset8 lr, sp, 8
; 23: 28 1d 1b load64 fp, sp
; 26: 14 1e 10 xconst8 spilltmp0, 16
; 29: 18 7b 7b xadd32 sp, sp, spilltmp0
; 2c: 00 ret

46 changes: 46 additions & 0 deletions cranelift/filetests/filetests/isa/pulley64/stack_addr.clif
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
test compile precise-output
target pulley64

function %ret_stack() -> i64 {
ss0 = explicit_slot 4
block0():
v0 = stack_addr.i64 ss0
return v0
}

; VCode:
; x30 = xconst8 -16
; x27 = xadd32 x27, x30
; store64 sp+8, x28 // flags = notrap aligned
; store64 sp+0, x29 // flags = notrap aligned
; x29 = xmov x27
; x30 = xconst8 -16
; x27 = xadd32 x27, x30
; block0:
; x0 = load_addr Slot(0)
; x30 = xconst8 16
; x27 = xadd32 x27, x30
; x28 = load64_u sp+8 // flags = notrap aligned
; x29 = load64_u sp+0 // flags = notrap aligned
; x30 = xconst8 16
; x27 = xadd32 x27, x30
; ret
;
; Disassembled:
; 0: 14 1e f0 xconst8 spilltmp0, -16
; 3: 18 7b 7b xadd32 sp, sp, spilltmp0
; 6: 32 1b 08 1c store64_offset8 sp, 8, lr
; a: 30 1b 1d store64 sp, fp
; d: 11 1d 1b xmov fp, sp
; 10: 14 1e f0 xconst8 spilltmp0, -16
; 13: 18 7b 7b xadd32 sp, sp, spilltmp0
; 16: 11 00 1b xmov x0, sp
; 19: 14 1e 10 xconst8 spilltmp0, 16
; 1c: 18 7b 7b xadd32 sp, sp, spilltmp0
; 1f: 2b 1c 1b 08 load64_offset8 lr, sp, 8
; 23: 28 1d 1b load64 fp, sp
; 26: 14 1e 10 xconst8 spilltmp0, 16
; 29: 18 7b 7b xadd32 sp, sp, spilltmp0
; 2c: 00 ret