Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag pulley as not supporting most wasm features #9648

Merged

Conversation

alexcrichton
Copy link
Member

This commit updates Config::compiler_panicking_wasm_features to include most wasm features for pulley targets. These backends in Cranelift don't support most instructions at this time and have lots of todo!()-related panics here and there. This won't completely cover all panics but it's at least a start.

This commit updates `Config::compiler_panicking_wasm_features` to
include most wasm features for pulley targets. These backends in
Cranelift don't support most instructions at this time and have lots of
`todo!()`-related panics here and there. This won't completely cover all
panics but it's at least a start.
@alexcrichton alexcrichton requested a review from a team as a code owner November 21, 2024 16:40
@alexcrichton alexcrichton requested review from pchickey and removed request for a team November 21, 2024 16:40
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Nov 21, 2024
Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@alexcrichton alexcrichton added this pull request to the merge queue Nov 21, 2024
Merged via the queue into bytecodealliance:main with commit 8fd6208 Nov 21, 2024
40 checks passed
@alexcrichton alexcrichton deleted the pulley-filter-wasm-features branch November 21, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants