wasi-http: add the port to authority when opening a TCP connection #8671
Conversation
|
What if the program explicitly specified a port different from 80 or 443? Wouldn't this change break that by creating a nonsensical address like |
Indeed, I didn't consider that. I will update it again. |
iawia002
force-pushed
the
fix-invalid-socket-address
branch
from
ede4253 to
326b512
Compare
|
Does this mean that Would you be up for adding a test for this? |
I think that that is the case, could we have a fix like this one on a 21.0.1 version? |
|
Yeah, definitely seems bad enough for a point release! Would you be up for adding a test here? perhaps fetching something like |
iawia002
force-pushed
the
fix-invalid-socket-address
branch
from
326b512 to
4f2cee2
Compare
iawia002
force-pushed
the
fix-invalid-socket-address
branch
from
4f2cee2 to
909b68d
Compare
|
I have added a test for this case, following @elliottt's advice in #8676 (comment), PTAL @alexcrichton @elliottt |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Could you remove the use of ssl in your test program? CI failed because it's not supported on riscv64. |
|
Ah I went ahead and just pushed up a commit to ignore s390x/riscv64, I don't think it's too critical to get all the architectures tested here |
…ytecodealliance#8671) * wasi-http: add the port to authority when opening a TCP connection * Ignore test on riscv64 and s390x --------- Co-authored-by: Alex Crichton <[email protected]>
…8671) (#8678) * wasi-http: add the port to authority when opening a TCP connection * Ignore test on riscv64 and s390x --------- Co-authored-by: Xinzhao Xu <[email protected]>
This handles flakiness [seen online] and makes the test more robust. It was known that this test was not "fully robust" when added in bytecodealliance#8671 and this is the "work over time" to handle failures we see in the wild. [seen online]: https://github.com/bytecodealliance/wasmtime/actions/runs/9324271722/job/25669233977
This handles flakiness [seen online] and makes the test more robust. It was known that this test was not "fully robust" when added in #8671 and this is the "work over time" to handle failures we see in the wild. [seen online]: https://github.com/bytecodealliance/wasmtime/actions/runs/9324271722/job/25669233977
#8563 removes the port from the authority, it makes the target address cannot be correctly resolved when opening a TCP connection. This results in that if we want to send an HTTP request in the wasi component, an error
ErrorCode::ConnectionRefusedwill be reported directly. The underlying error isinvalid socket address:/cc @alexcrichton @elliottt