Move the wasi-tests crate to the main workspace
#724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the upstream wasm32-wasi target has been fixed, we should be good to go!
We don't know what version of the wasi api it's compiled against, so let's avoid it.
The previous comment indicated that this was necessary to separate the build directories but that's already happening due to the usage of `--target-dir`, so there's no need for `wasi-tests` to live in a separate part of the workspace.
alexcrichton
force-pushed
the
more-workspace-crates
branch
from
c9428e8 to
6c830a8
Compare
|
For somewhat obtuse reasons this is rebased on #723 now to get windows tests passing |
|
Alas looks like MSVC has more issues than I thought! I think that we may not be quite ready for this yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous comment indicated that this was necessary to separate the
build directories but that's already happening due to the usage of
--target-dir, so there's no need forwasi-teststo live in aseparate part of the workspace.