Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some more fuzz-test cases from pooling changes #6943

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

alexcrichton
Copy link
Member

This commit addresses some more fallout from #6835 by updating some
error messages and adding clauses for new conditions. Namely:

  • Module compilation is now allowed to fail when the module may have
    more memories/tables than the pooling allocator allows per-module.
  • The error message for the core instance limit being reached has been
    updated.

This commit addresses some more fallout from bytecodealliance#6835 by updating some
error messages and adding clauses for new conditions. Namely:

* Module compilation is now allowed to fail when the module may have
  more memories/tables than the pooling allocator allows per-module.
* The error message for the core instance limit being reached has been
  updated.
@alexcrichton alexcrichton requested review from a team as code owners August 31, 2023 15:07
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team August 31, 2023 15:07
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen added this pull request to the merge queue Aug 31, 2023
Merged via the queue into bytecodealliance:main with commit 1a11e25 Aug 31, 2023
@alexcrichton alexcrichton deleted the fix-fuzz branch August 31, 2023 17:02
eduardomourar pushed a commit to eduardomourar/wasmtime that referenced this pull request Sep 6, 2023
…6943)

* Fix some warnings on nightly Rust

* Fix some more fuzz-test cases from pooling changes

This commit addresses some more fallout from bytecodealliance#6835 by updating some
error messages and adding clauses for new conditions. Namely:

* Module compilation is now allowed to fail when the module may have
  more memories/tables than the pooling allocator allows per-module.
* The error message for the core instance limit being reached has been
  updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants