Derive Copy on wasmtime::ValType
#6138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ValType` is small enough that it can be copiable. Doing so means Copy types can embed a `ValType` in them. The need for this came up in this Wasmtime Ruby PR: bytecodealliance/wasmtime-rb#158
github-actions
bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
pchickey
approved these changes
Apr 4, 2023
|
Is this still possible once the gc proposal is implemented? Wouldn't this enum get variants that use heap allocated values to represent gc types? Types containing heap allocated values can't be Copy. |
|
Probably it will get variants that are indices into ... somewhere. |
|
We might have to remove |
|
Understood. We'll use it while we can, and adjust our strategy if ever it gets dropped. Thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValTypeis small enough that it can be copiable. By makingValTypeCopy,Copystructs can haveValTypefields in them.The need for this came up in bytecodealliance/wasmtime-rb#158. By making
ValTypeCopy, we could get rid of this workaround.