Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cranelift: Implement {u,s}extend.i128 in interpreter #4505

Merged
merged 1 commit into from
Jul 22, 2022
Merged

cranelift: Implement {u,s}extend.i128 in interpreter #4505

merged 1 commit into from
Jul 22, 2022

Conversation

afonso360
Copy link
Contributor

@afonso360 afonso360 commented Jul 22, 2022 •
edited
Loading

👋 Hey, a few missing ops for the interpreter.

This was discovered by fuzzgen after fixing the switch API.

CC: #4502
CC: @jameysharp

@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Jul 22, 2022
jameysharp
jameysharp approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me!

@jameysharp jameysharp merged commit d89c262 into bytecodealliance:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameysharp jameysharp jameysharp approved these changes

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afonso360 @jameysharp