Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi-http: Manage outgoing connections with a callback on WasiHttpCtx #7259

Closed
elliottt opened this issue Oct 16, 2023 · 1 comment · Fixed by #7288
Closed

wasi-http: Manage outgoing connections with a callback on WasiHttpCtx #7259

elliottt opened this issue Oct 16, 2023 · 1 comment · Fixed by #7288
Assignees
@dicej

Comments

@elliottt
Copy link
Member

elliottt commented Oct 16, 2023 •
edited
Loading

Currently all outgoing connections assume http 1, and a specific tls library. We need to refactor this so that the logic for constructing the hyper::SendRequest<_> and spawning the connection handling task are done by a callback defined on the WasiHttpCtx instead.
@elliottt elliottt converted this from a draft issue Oct 16, 2023
@elliottt elliottt self-assigned this Oct 16, 2023
@dicej dicej assigned dicej and unassigned elliottt Oct 18, 2023
@dicej
Copy link
Contributor

dicej commented Oct 18, 2023

I'm going to work on this today and try to get it backported to Wasmtime 14 before it's released.

dicej added a commit to dicej/wasmtime that referenced this issue Oct 18, 2023
@dicej
wasi-http: Allow embedder to manage outgoing connections
0a531e7 
This adds a new `send_request` method to `WasiHttpView`, allowing embedders to
override the default implementation with their own if the desire.  The default
implementation behaves exactly as before.

I've also added a few new `wasi-http` tests: one to test the above, and two
others to test streaming and concurrency.  These tests are ports of the
`test_wasi_http_echo` and `test_wasi_http_hash_all` tests in the
[Spin](https://github.com/fermyon/spin) integration test suite.  The component
they instantiate is likewise ported from the Spin
`wasi-http-rust-streaming-outgoing-body` component.

Fixes bytecodealliance#7259

Signed-off-by: Joel Dice <[email protected]>
dicej added a commit to dicej/wasmtime that referenced this issue Oct 18, 2023
@dicej
wasi-http: Allow embedder to manage outgoing connections
bf7b408 
This adds a new `send_request` method to `WasiHttpView`, allowing embedders to
override the default implementation with their own if the desire.  The default
implementation behaves exactly as before.

I've also added a few new `wasi-http` tests: one to test the above, and two
others to test streaming and concurrency.  These tests are ports of the
`test_wasi_http_echo` and `test_wasi_http_hash_all` tests in the
[Spin](https://github.com/fermyon/spin) integration test suite.  The component
they instantiate is likewise ported from the Spin
`wasi-http-rust-streaming-outgoing-body` component.

Fixes bytecodealliance#7259

Signed-off-by: Joel Dice <[email protected]>
@dicej dicej mentioned this issue Oct 18, 2023
Merged
dicej added a commit to dicej/wasmtime that referenced this issue Oct 18, 2023
@dicej
wasi-http: Allow embedder to manage outgoing connections
c1f982e 
This adds a new `send_request` method to `WasiHttpView`, allowing embedders to
override the default implementation with their own if the desire.  The default
implementation behaves exactly as before.

I've also added a few new `wasi-http` tests: one to test the above, and two
others to test streaming and concurrency.  These tests are ports of the
`test_wasi_http_echo` and `test_wasi_http_hash_all` tests in the
[Spin](https://github.com/fermyon/spin) integration test suite.  The component
they instantiate is likewise ported from the Spin
`wasi-http-rust-streaming-outgoing-body` component.

Fixes bytecodealliance#7259

Signed-off-by: Joel Dice <[email protected]>
dicej added a commit to dicej/wasmtime that referenced this issue Oct 18, 2023
@dicej
wasi-http: Allow embedder to manage outgoing connections
605d839 
This adds a new `send_request` method to `WasiHttpView`, allowing embedders to
override the default implementation with their own if the desire.  The default
implementation behaves exactly as before.

I've also added a few new `wasi-http` tests: one to test the above, and two
others to test streaming and concurrency.  These tests are ports of the
`test_wasi_http_echo` and `test_wasi_http_hash_all` tests in the
[Spin](https://github.com/fermyon/spin) integration test suite.  The component
they instantiate is likewise ported from the Spin
`wasi-http-rust-streaming-outgoing-body` component.

Fixes bytecodealliance#7259

Signed-off-by: Joel Dice <[email protected]>
dicej added a commit to dicej/wasmtime that referenced this issue Oct 18, 2023
@dicej
wasi-http: Allow embedder to manage outgoing connections
7deaae4 
This adds a new `send_request` method to `WasiHttpView`, allowing embedders to
override the default implementation with their own if the desire.  The default
implementation behaves exactly as before.

I've also added a few new `wasi-http` tests: one to test the above, and two
others to test streaming and concurrency.  These tests are ports of the
`test_wasi_http_echo` and `test_wasi_http_hash_all` tests in the
[Spin](https://github.com/fermyon/spin) integration test suite.  The component
they instantiate is likewise ported from the Spin
`wasi-http-rust-streaming-outgoing-body` component.

Fixes bytecodealliance#7259

Signed-off-by: Joel Dice <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2023
@dicej
wasi-http: Allow embedder to manage outgoing connections (#7288)
cc3bf3c 
This adds a new `send_request` method to `WasiHttpView`, allowing embedders to
override the default implementation with their own if the desire.  The default
implementation behaves exactly as before.

I've also added a few new `wasi-http` tests: one to test the above, and two
others to test streaming and concurrency.  These tests are ports of the
`test_wasi_http_echo` and `test_wasi_http_hash_all` tests in the
[Spin](https://github.com/fermyon/spin) integration test suite.  The component
they instantiate is likewise ported from the Spin
`wasi-http-rust-streaming-outgoing-body` component.

Fixes #7259

Signed-off-by: Joel Dice <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dicej dicej

Labels
None yet
Projects
Ship WASI Preview 2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wasi-http: Allow embedder to manage outgoing connections dicej/wasmtime
2 participants
@elliottt @dicej