Added support for Linker.DefineFunction with generic tuples #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parameter.
Previously defining this would work:
```csharp
Linker.DefineFunction<int, (int, int)>("module", "name", (int a) => (a, a));
```
But doing this would not work:
```csharp
void DefineWrapper<TIn, TOut>(Func<TIn, TOut> func)
{
Linker.DefineFunction<TIn, TOut>("module", "name", func);
}
DefineWrapper<int, (int, int)>((int a) => (a, a));
```
Even though they're ultimately doing the same thing, just with one more level of generic typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for defining functions which have a tuple as a generic parameter.
Previously defining like this would work:
But doing this would not work:
Even though they're ultimately doing the same thing, just with one more level of generic typing.
This PR detects that case and adds limited support for tuples (only up to 4 elements).
I have not added support for
ValueRawunboxing of tuples. As far as I can tell it's not required anywhere.