Added TableKind for tables
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sents the range of type a `Table` may contain.
…ind` to steer people towards the new constructor.
peterhuene
reviewed
Jul 5, 2023
|
Oh sorry, I must have missed those. I'll fix them now. |
peterhuene
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
ValueKindwithTableKindinTable. This properly represents the range of type aTablemay contain. I've minimised the amount of breakage by still acceptingValueKindin the constructor (marked with anObsoleteattribute, to steer peope towards the new constructor).This is a small improvement (it provides a hint at valid table types) but it is still a bit fragile. It's very easy to use an incorrect
Kindor to pass an incorrect type intoSetElement. We may want to improve on that in the future (e.g. type safe table wrappers, like we have for globals).