Fix a race condition in some tests #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were modeled as "do a thing piped into another thing" but the second command didn't actually take any input. That meant that writing the stdout of the previous command into the next command might sometimes fail if the second command finishes before the write finishes. This commit fixes the various affected tests with the now-added ability to run multiple separate commands in a single file. These failures were detected by inserting a `sleep` before writing stdin and then fixing all tests. Closes bytecodealliance#1820
|
I can confirm I have not been able to reproduce any issue reported in #1820 with this PR. Thanks! |
abrown
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were modeled as "do a thing piped into another thing" but the second command didn't actually take any input. That meant that writing the stdout of the previous command into the next command might sometimes fail if the second command finishes before the write finishes. This commit fixes the various affected tests with the now-added ability to run multiple separate commands in a single file. These failures were detected by inserting a
sleepbefore writing stdin and then fixing all tests.Closes #1820