Maintain more internal consistency checks when merging worlds #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll note that this is stacked on #1791 so the first commit can be ignored. |
dicej
approved these changes
Sep 17, 2024
This commit fixes two issues, both preexisting, which represented violated invariants of a `Resolve` after worlds were merged. World merging is used during component generation and might be used for bindings generation so it's important to maintain the various dynamic invariants of `Resolve` to ensure that surrounding tooling works. An example of this is that printing a merged world doesn't produce parseable WIT today because some of the internal invariants aren't respected. This commit beefs up the `Resolve::assert_valid` function and then applies necessary fixes to resolve these assertion failures on preexisting test cases. The main difference is that anonymous interfaces/types are now "cloned" when they move from one world to another. This is required to ensure that all the various links between these items are consistent and point to the right place. This cloning infrastructure may end up being more generalized in the future if the need arises, but for now it's quite limited.
alexcrichton
force-pushed
the
clone-on-merge
branch
from
d55ce5f
to
4e6bd5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two issues, both preexisting, which represented
violated invariants of a
Resolveafter worlds were merged. Worldmerging is used during component generation and might be used for
bindings generation so it's important to maintain the various dynamic
invariants of
Resolveto ensure that surrounding tooling works. Anexample of this is that printing a merged world doesn't produce
parseable WIT today because some of the internal invariants aren't
respected.
This commit beefs up the
Resolve::assert_validfunction and thenapplies necessary fixes to resolve these assertion failures on
preexisting test cases. The main difference is that anonymous
interfaces/types are now "cloned" when they move from one world to
another. This is required to ensure that all the various links between
these items are consistent and point to the right place. This cloning
infrastructure may end up being more generalized in the future if the
need arises, but for now it's quite limited.