Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing rectypes in components #1764

Merged
merged 7 commits into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. Allow parsing rectypes in components

    This change supports [bytecodealliance#392], which adds a way to use GC's `rectypes` as
    type definitions in components. Previously, only function types were
    supported and there was no way express array and struct types. This
    keeps the previous function decoding support based on peeking the
    function type `0x60` prefix but adds support for encoding `rectypes`
    with a new `0x00` prefix.
    
    [bytecodealliance#392]: WebAssembly/component-model#392
    
    Co-authored-by: Alex Crichton <[email protected]>
    abrown and alexcrichton committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    10f61c1 View commit details
    Browse the repository at this point in the history
  2. Apply 0x00 prefix to non-final sub; add tests

    This follows along with the most recent discussion in the component
    model PR ([bytecodealliance#392]).
    
    [bytecodealliance#392]: WebAssembly/component-model#392
    
    Co-authored-by: Alex Crichton <[email protected]>
    abrown and alexcrichton committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7273f43 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c466566 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8943953 View commit details
    Browse the repository at this point in the history
  5. review: remove resolved TODOs

    abrown committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5d182e3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e4847d7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e6be634 View commit details
    Browse the repository at this point in the history