WIT: Implement @since and @unstable annotations #1508
Merged
Commits on May 28, 2024
-
-
Preserve error context when highlighting errors
Previously the entire error message was replaced, losing any attached context. This commit updates error highlighting to only augment the single error found in the chain that's being highlighted (in the most common case). This required a small refactoring of the `Error` type and changes all existing users to a method-based constructor rather than explicit struct-based construction.
-
Add initial parsing of attributes
Nothing uses the results of parsing yet, that's going to come in a future commit.
-
Record spans for all types in
UnresolvedPackageWill be used for errors in a future commit.
-
Push stability attributes into top-level AST
This commit pushes stability attributes through the resolution process to the next stage of AST. The top-level user-facing types in `wit-parser` now have `Stability` annotations were they can be added. This commit notably changes the `WorldItem::Interface` enum variant to contain a stability attribute in addition to the id listed.
-
Filter out
@unstableitems that aren't enabledThis finishes support for `@unstable` and `@since` in `Resolve` by handling all items there and specifically filtering out any disabled items.
-
-
-
Round-trip stability through the wasm binary format
This involved a number of refactorings and "tricks" to get this to work out. Namely when possible the old format of the custom section is still emitted to ensure older/newer tools can interoperate when possible.
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.