-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wit-parser::decoding::decode
should error when given a core module
#1673
Comments
One use case of passing a core module is that there's these
|
I have used |
Also cause it to return an error if the input is a core wasm module with zero `component-type` custom sections. Closes bytecodealliance#1673
Also cause it to return an error if the input is a core wasm module with zero `component-type` custom sections. Closes #1673
wit-parser::decoding::decode
requires a WebAssembly component (either as a normal component or as a WIT-package-encoded-as-binary). However, if you pass in a core module, everything "works" (i.e., no error is returned), but you end up with an empty resolve. I imagine the right thing to do here would be to error specifying that a component must be passed.Let me know if this is the case, and I can submit a fix.
The text was updated successfully, but these errors were encountered: