Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows wamrc and iwasm build in release CI #3857

Merged
merged 25 commits into from
Oct 17, 2024
Merged

Add Windows wamrc and iwasm build in release CI #3857

merged 25 commits into from
Oct 17, 2024

Conversation

TianlongLiang
Copy link
Contributor

  • For Windows, llvm libs need to cache more directories, so use a multi-line environment variable for paths
  • Remove conditionally build directories win32build, just use build for all platform
  • Add Windows wamrc and iwasm(disable lib pthread semaphore and fast jit for now) build in release CI

wenyongh
wenyongh approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

.github/workflows/build_llvm_libraries.yml Outdated Show resolved Hide resolved
@TianlongLiang
release CI: Windows artifact
999a9f4
@TianlongLiang
release CI: Windows llvm lib, iwasm and wamrc
80bedf1
@TianlongLiang
use build for llvm libraries build diretory for all platform
b3cfbfe
@TianlongLiang
use build for llvm libraries build diretory for all platform, conditi…
9be909c 
…onally set multi-line separator in CI
@TianlongLiang
some update
09da8e9
@TianlongLiang
some update
df36be8
@TianlongLiang
some update
2a5280c
@TianlongLiang
some update
e95bd37
@TianlongLiang
some update
072cf8f
@TianlongLiang
some update
a0fa71e
@TianlongLiang
some update
63e18c0
@TianlongLiang
"conditionally extra llvm paths on Windows"
ed31d8a
@TianlongLiang
disable fast jit on Windows for now
e7b0005
@TianlongLiang
use multi-line environment variable for llvm lib cache paths for wind…
b6e23d0 
…ows compatibility
@TianlongLiang
use multi-line environment variable for llvm lib cache paths for wind…
6dc917c 
…ows compatibility
@TianlongLiang
disable lib pthread on Windows iwasm
97d37d9
@TianlongLiang
disable lib pthread semaphore on Windows iwasm
d9e352b
@TianlongLiang
some update
d69e3e0
@TianlongLiang
some update
c4d317a
@TianlongLiang
cr suggestions
639cc53
@wenyongh wenyongh merged commit 1af4740 into bytecodealliance:main Oct 17, 2024
383 checks passed
Zzzabiyaka pushed a commit to Zzzabiyaka/wasm-micro-runtime that referenced this pull request Oct 22, 2024
@TianlongLiang @Zzzabiyaka
Add Windows wamrc and iwasm build in release CI (bytecodealliance#3857)
99a1a07 
- For Windows, llvm libs need to cache more directories, so use a multi-line
  environment variable for paths
- Remove conditionally build directories `win32build`, just use `build` for all platform
- Add Windows wamrc and iwasm(disable lib pthread semaphore and fast jit for now)
  build in release CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lum1n0us lum1n0us lum1n0us left review comments

@wenyongh wenyongh wenyongh approved these changes

@no1wudi no1wudi no1wudi approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TianlongLiang @no1wudi @wenyongh @lum1n0us