Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_native_lib that is used by iwasm to load wasi-nn as a native library #3817

Closed
wants to merge 2 commits into from

Conversation

rodjjo
Copy link

@rodjjo rodjjo commented Sep 26, 2024

What

  • When it was running the example from wasm-micro-runtime/core/iwasm/libraries/wasi-nn there was an error where iwasm was not able to register the functions into the wasm vm.
  • Fix a typo in core/iwasm/libraries/wasi-nn/test/utils.c

Why

We need get_native_lib in order to use --native-lib=path-to-lib.so missing for this wasi-nn library.

Note

I kept get_wasi_nn_export_apis as it was as i did not know where it is used.

Now it runs:
image

@rodjjo rodjjo changed the title Add get_native_lib that is used by iwasm to load modules Add get_native_lib that is used by iwasm to load wasi-nn as a native library Sep 26, 2024
@rodjjo
Copy link
Author

rodjjo commented Sep 26, 2024

image
I guess we have an unstable test there. I just included a empty line (I would never affect the tests).

@wenyongh
Copy link
Contributor

image I guess we have an unstable test there. I just included a empty line (I would never affect the tests).

Yes, the CI sometimes encounters error, e.g. failed to download packages. I re-ran it and now it works.

Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us
Copy link
Collaborator

Please test with #3820

By design, --native-lib is not required.

Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test with #3820

Refer to core/iwasm/libraries/wasi-nn/README.md in #3820

@rodjjo
Copy link
Author

rodjjo commented Sep 28, 2024

@lum1n0us I made questions/suggestions on your PR.
I'm closing this one due your changes there.

@rodjjo rodjjo closed this Sep 28, 2024
wenyongh pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants