Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlook the access modes of STDIN, STDOUT and STDERR #3694

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Overlook the access modes of STDIN, STDOUT and STDERR #3694

merged 1 commit into from
Aug 13, 2024
+138 −19

Conversation

lum1n0us
Copy link
Collaborator

@lum1n0us lum1n0us commented Aug 7, 2024

@lum1n0us lum1n0us force-pushed the fix/overlook_stdio_access_modes branch 3 times, most recently from 433cdc7 to b1e2ec3 Compare August 8, 2024 04:01
@wenyongh wenyongh mentioned this pull request Aug 8, 2024
Closed
@lum1n0us lum1n0us force-pushed the fix/overlook_stdio_access_modes branch 2 times, most recently from e0bec0e to 68835f9 Compare August 12, 2024 07:06
@lum1n0us lum1n0us force-pushed the fix/overlook_stdio_access_modes branch from 68835f9 to e9f1243 Compare August 12, 2024 11:15
wenyongh
wenyongh approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 67fa155 into bytecodealliance:main Aug 13, 2024
385 checks passed
@lum1n0us lum1n0us deleted the fix/overlook_stdio_access_modes branch November 20, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lum1n0us @wenyongh