Fix a compilation warning #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1wudi
commented
Aug 2, 2024
Fix:
```
wamr/core/iwasm/compilation/aot_llvm.c: In function ‘insert_native_symbol’:
wamr/core/iwasm/compilation/aot_llvm.c:3290:28: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
3290 | if (ret < 0 || ret + 1 > sizeof(sym->symbol)) {
| ^
```
Signed-off-by: Huang Qi <[email protected]>
no1wudi
force-pushed
the
main
branch
2 times, most recently
from
4321a18
to
2492383
Compare
yamt
approved these changes
Aug 2, 2024
| @@ -3287,7 +3287,7 @@ insert_native_symbol(AOTCompContext *comp_ctx, const char *symbol, int32 idx) | |||
| memset(sym, 0, sizeof(AOTNativeSymbol)); | |||
| bh_assert(strlen(symbol) <= sizeof(sym->symbol)); | |||
| ret = snprintf(sym->symbol, sizeof(sym->symbol), "%s", symbol); | |||
| if (ret < 0 || ret + 1 > sizeof(sym->symbol)) { | |||
| if (ret < 0 || ret + 1 > (int)sizeof(sym->symbol)) { | |||
There was a problem hiding this comment.
in general i prefer to cast to the larger type. (size_t)
but i guess it doesn't matter for this specific code.
There was a problem hiding this comment.
Yes, the size of sym->symbol is is only 48 byte for this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: