spec-test-script: skip a few tests for xtensa #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the failure looks unrelated. https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/10073008291/job/27846255552 |
wenyongh
reviewed
Jul 24, 2024
| @@ -94,6 +94,10 @@ def ignore_the_case( | |||
| if "i386" == target and case_name in ["float_exprs", "conversions"]: | |||
| return True | |||
|
|
|||
| # esp32s3 qemu doesn't have PSRAM emulation | |||
| if target == 'xtensa' and case_name in ["memory_size"]: | |||
There was a problem hiding this comment.
Is it better to check qemu_flag also since some non-qemu environment may support the case?
There was a problem hiding this comment.
ok. it makes sense. done.
| @@ -833,6 +833,12 @@ def test_assert_return(r, opts, form): | |||
| if ' ' in func: | |||
| func = func.replace(' ', '\\') | |||
|
|
|||
| # Note: 'as-memory.grow-first' doesn't actually grow memory. | |||
| # (thus not in this list) | |||
| if opts.target == 'xtensa' and func in {'as-memory.grow-value', 'as-memory.grow-size', 'as-memory.grow-last', 'as-memory.grow-everywhere'}: | |||
There was a problem hiding this comment.
Same as above, had better check opts.qemu also?
wenyongh
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because these test cases require more memory than what nuttx on esp32s3 qemu can afford.