Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-check wrgsbase in cmake script #2437

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

wenyongh
Copy link
Contributor

@wenyongh wenyongh commented Aug 8, 2023

Auto-check whether WRGSBASE instruction is supported in linux x86-64 in the
cmake script. And if not, disable writing x86 GS register.

@wenyongh wenyongh mentioned this pull request Aug 8, 2023
@wenyongh wenyongh merged commit 490fa2d into bytecodealliance:main Aug 9, 2023
368 checks passed
@wenyongh wenyongh deleted the add_wrgsbase_check branch August 14, 2023 07:14
@ThomasDevoogdt
Copy link
Contributor

@wenyongh, this creates an error for cross compilation targets, can you make this try_run conditionally?
See https://cmake.org/cmake/help/latest/command/try_run.html#behavior-when-cross-compiling.

victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Auto-check whether `WRGSBASE` instruction is supported in linux x86-64 in the
cmake script. And if not, disable writing x86 GS register.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants