Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec_test_on_nuttx.yml should not edit kconfig files with sed #3646

Closed
yamt opened this issue Jul 19, 2024 · 0 comments · Fixed by #3672
Closed

spec_test_on_nuttx.yml should not edit kconfig files with sed #3646

yamt opened this issue Jul 19, 2024 · 0 comments · Fixed by #3672

Comments

@yamt
Copy link
Collaborator

yamt commented Jul 19, 2024

because it's fragile.
there are more appropriate tools to modify configs.
(eg. kconfig-tweak)
@yamt yamt mentioned this issue Jul 25, 2024
Merged
yamt added a commit to yamt/wasm-micro-runtime that referenced this issue Jul 29, 2024
@yamt
spec_test_on_nuttx.yml: replace sed with kconfig-tweak
2a66ff4 
Fixes: bytecodealliance#3646
@yamt yamt mentioned this issue Jul 29, 2024
Merged
yamt added a commit to yamt/wasm-micro-runtime that referenced this issue Jul 29, 2024
@yamt
spec_test_on_nuttx.yml: replace sed with kconfig-tweak
e48f35c 
Fixes: bytecodealliance#3646
yamt added a commit to yamt/wasm-micro-runtime that referenced this issue Jul 29, 2024
@yamt
spec_test_on_nuttx.yml: replace sed with kconfig-tweak
b361b02 
Fixes: bytecodealliance#3646
wenyongh pushed a commit that referenced this issue Jul 31, 2024
@yamt
spec_test_on_nuttx.yml: Replace sed with kconfig-tweak (#3672)
c3bd6b4 
Fixes: #3646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spec_test_on_nuttx.yml: replace sed with kconfig-tweak yamt/wasm-micro-runtime
1 participant
@yamt