Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic example of wac CLI and programatic API #107

Merged
merged 2 commits into from
May 15, 2024

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented May 13, 2024

Fixes #51

This adds a simple example showing how wac encode, wac plug, and the wac-graph API work.

@rylev rylev requested a review from peterhuene May 13, 2024 12:07
@FrankReh
Copy link

Would there be any value in the README for this example also saying why wac plug could or could not be used to compose also?

I don't think it's confusing to see what the options are. On the contrary, I'm confused when I think there are other options that aren't mentioned.

examples/README.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@fibonacci1729 fibonacci1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix for the name of the wac document used and optional clarifying question.

Looks great!

Signed-off-by: Ryan Levick <[email protected]>
@rylev
Copy link
Collaborator Author

rylev commented May 14, 2024

I tried to address all the feedback here. Let me know what you think!

@FrankReh
Copy link

FrankReh commented May 14, 2024

Wow! Your README is really nice. It very quickly gets to the point and shows three ways of using wac to compose.

I don't think there is any need to provide pros and cons for the various options (which you don't). Anyone reading this will be used to being able to do things in multiple ways and will know that the pros and cons for their situation will become evident when they sit down and start using it.

@FrankReh
Copy link

This adds a simple example showing how both wac encode and the wac-graph API work

Maybe tweak this description, since it probably gets into the git log. The example shows how to use wac plug now also.

@rylev rylev merged commit 7a58bdb into bytecodealliance:main May 15, 2024
7 checks passed
@rylev rylev deleted the add-example branch May 15, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hello, world! Style example
3 participants