-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize shootout
benchmarks into a single directory
#260
Merged
Commits on Jun 30, 2023
-
Move all
shootout
benchmarks into a single directoryNow that bytecodealliance#251 and bytecodealliance#256 make it possible for more than one benchmark to live in a single directory, this change moves all of the shootout artifacts into a single directory. This simply performs the file movement; subsequent commits will make necessary tweaks.
Configuration menu - View commit details
-
Copy full SHA for 955eade - Browse repository at this point
Copy the full SHA 955eadeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1885f51 - Browse repository at this point
Copy the full SHA 1885f51View commit details
Commits on Jul 5, 2023
-
Enable native benchmarking in new
shootout
directoryThis change refactors how the shootout native benchmarks are built. The `Dockerfile.native` file is retained and is expected to be _the_ way to build the native shared libraries for this kind of benchmarking. A `build-native.sh` script is included in the directory to (a) be used by `Dockerfile.native` and (b) for building the native benchmarks in environments where running Docker may not be possible. Now that all of the benchmarks are built in one directory, the native libraries cannot all be named `benchmark.so`. Because of this and the hard-coded path expected by the native engine (see bytecodealliance#259), this change also modifies the associated `*-native.sh` scripts to set up a temporary directory that looks like the `benchmark.so` environment that was there previously. This additional logic could be removed once bytecodealliance#259 is fixed.
Configuration menu - View commit details
-
Copy full SHA for 069e089 - Browse repository at this point
Copy the full SHA 069e089View commit details
Commits on Jul 6, 2023
-
Remove the original
shootout-*
directoriesThese are all migrated over to be a part of the single `shootout` directory.
Configuration menu - View commit details
-
Copy full SHA for 39ac022 - Browse repository at this point
Copy the full SHA 39ac022View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fa4458 - Browse repository at this point
Copy the full SHA 4fa4458View commit details -
Update
ackermann
to use new*.input
pathsThe new file structure for `shootout` now expects these paths to look like `shootout-ackermann.*.input`.
Configuration menu - View commit details
-
Copy full SHA for 7aa543c - Browse repository at this point
Copy the full SHA 7aa543cView commit details -
When we allocate the array to sort, we should do so with items of size `double` (64 bits) instead of `double*` (32 bits in WebAssembly). I am very confused as to why this benchmark worked previously, but when I recompiled it prior to this change, it would invariably fail due to accessing addresses beyond the memory bounds.
Configuration menu - View commit details
-
Copy full SHA for 8b9855b - Browse repository at this point
Copy the full SHA 8b9855bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84a3621 - Browse repository at this point
Copy the full SHA 84a3621View commit details -
This change fixes some issues highlighted by CI: - it adds more verbose output to see which commands are executed - it improves the documentation to clarify how to use certain flags - it fixes slight mistakes in the scripts missed by previous refactoring - and, __most especially__, it alters the order of the parameters passed to compile the native libraries. This last change is indicative of the fragility of the native benchmarks: apparently moving `-lengine` to the end was necessary for the linker to understand which library provides `bench_start` and `bench_end`.
Configuration menu - View commit details
-
Copy full SHA for dd76047 - Browse repository at this point
Copy the full SHA dd76047View commit details
Commits on Jul 7, 2023
-
Now that `Dockerfile.native` relies on a script, `build-native.sh`, instead of the Cargo build system, the documentation for building native libraries has to change.
Configuration menu - View commit details
-
Copy full SHA for 9b6f718 - Browse repository at this point
Copy the full SHA 9b6f718View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.