-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add sendmsg/recvmsg #505
Conversation
Great to see this come, recvmsg would make this a potential backend for the async variety of the std-embedded-nal crate. Given that this is in |
I'm interested in this, I'd like to add |
Re: both comments above, my motivating use case for this PR is using Since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I've now made a preliminary pass with a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've now read through the whole PR. Overall this looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for one more round of review here, but I did find a few more things here.
No problem! Especially for a crate like |
Thanks! |
This is now released in rustix 0.37.16 |
This PR adds the
sendmsg_*
/recvmsg
family of functions. It also adds structs for dealing with ancillary data. Some of the code here is taken from #159.Very WIP for now