Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path buffer reuse #163

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Path buffer reuse #163

merged 2 commits into from
Jan 10, 2022

Conversation

inteon
Copy link
Contributor

@inteon inteon commented Jan 9, 2022

Reuse full vector capacity when reusing buffers.
PR also includes some other cleanups.

@inteon inteon changed the title Path buffer size Path buffer reuse Jan 9, 2022
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'm a fan of cleanup patches!

src/fs/at.rs Outdated Show resolved Hide resolved
src/ffi/z_str.rs Outdated Show resolved Hide resolved
src/fs/at.rs Outdated Show resolved Hide resolved
src/fs/at.rs Show resolved Hide resolved
src/path/arg.rs Outdated Show resolved Hide resolved
src/path/arg.rs Outdated Show resolved Hide resolved
src/path/mod.rs Outdated Show resolved Hide resolved
@sunfishcode sunfishcode merged commit eed16ae into bytecodealliance:main Jan 10, 2022
@sunfishcode
Copy link
Member

Looks great, thanks!

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 6, 2022
Cleanup c_str.rs

Some code cleanups in `c_str.rs`.
No functional changes.

ref: bytecodealliance/rustix#163
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 7, 2022
Cleanup c_str.rs

Some code cleanups in `c_str.rs`.
No functional changes.

ref: bytecodealliance/rustix#163
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 7, 2022
Cleanup c_str.rs

Some code cleanups in `c_str.rs`.
No functional changes.

ref: bytecodealliance/rustix#163
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Feb 7, 2022
Cleanup c_str.rs

Some code cleanups in `c_str.rs`.
No functional changes.

ref: bytecodealliance/rustix#163
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Feb 7, 2022
Cleanup c_str.rs

Some code cleanups in `c_str.rs`.
No functional changes.

ref: bytecodealliance/rustix#163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants