fastly js-compute-runtime patches on top of SM 127.0.2 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
JakeChampion
force-pushed
the
fastly/ff-127-0-2
branch
from
5691dcf to
194f946
Compare
Revert "Bug 1795914 - Remove JS Streams implementation r=jandem" This reverts commit 4852cc8. Revert "Bug 1807845 - Remove the dom.streams prefs r=evilpie,emilio" This reverts commit 15d6982. Revert "Bug 1755391 - Remove JS Streams implementation of Writable Stream and PipeTo r=jandem" This reverts commit f83d513. Revert "Bug 1522136 - Remove javascript.options.streams and other legacy prefs. r=mgaudet,webidl,edgar" This reverts commit c256578. Revert "Bug 1765060 - Remove dead JS streams code. r=mgaudet" This reverts commit 75cea93. Revert "Bug 1774691 - Remove unused JSMSGs. r=mgaudet" This reverts commit b54b833. Revert "Bug 1774672 - Remove no longer neaded JS Streams Magic Values r=iain" This reverts commit d1c4d10. Revert "Bug 1776013 - Consume mfbt SIMD for String builtins r=iain" This reverts commit f81ba5c. Revert "Bug 1779807 - Consume SIMD::memchr64 for array includes/indexof r=iain" This reverts commit 557de26. Add the 'js/Stream.h' include back into 'vm/Runtime.h' Add JSAPI functions for operating on ReadableStream and WritableStream This adds a few functions for working with ReadableStream, plus introduces a basic set of ones for working with WritableStreams at all. This patch also includes updates to some of the doc comments for the existing streams API: for many functions the doc comment said that they assert that a passed `Handle<JSObject*>` is (a wrapper for) a specific type, but in reality the function does a check and throws an error instead of asserting. Since this patch introduces a few functions that actually do assert, it seems important to ensure the different behavior is correctly documented. Fix bug in ReadableStream#pipeTo that causes a failed assert when two actions get queued that trigger a pipeTo shutdown This can happen e.g. when closing the readable and then erroring the writable end of the pipe in the same microtask. The Streams spec guards against this by just making Shutdown and ShutdownWithAction bail early if already shutting down, but the implementation was doing an upwrap of the source or destination stream that fails if not guarded by a shuttingDown check because the streams have already been cleared. Fix bugs in ReadableStream#pipeTo that prevent proper flushing of all pending write requests when the source is closed
Co-authored-by: Jake Champion <[email protected]>
This got lost when fdlibm was re-vendored, because the fix wasn't created as a patch in `modules/fdlibm/patches`. Upstreaming this change will require adding that patch file.
In long-running environments, it's desirable for the embedding to reset the random seed at controlled points in time. In particular, when running in WASI, a situation can occur where a VM snapshot is taken at build time using [Wizer](https://github.com/bytecodealliance/wizer), which is then loaded and used as the basis for running separate workloads many times over. If `Math.random()` was called during the initialization phase, this would cause all workloads to get the same results for all consecutive calls to `Math.random()`.
…rototype The flag was previously only respected for internal builtins, not classes defined by the embedding using `JS_InitClass`. That meant one couldn't use `JS_InitClass` to define classes without a globally available constructor.
This reverts commit f81ba5c.
…of r=iain" This reverts commit 557de26.
JakeChampion
force-pushed
the
fastly/ff-127-0-2
branch
3 times, most recently
from
3603111 to
ced8341
Compare
added 3 commits
July 11, 2024 09:57
JakeChampion
force-pushed
the
fastly/ff-127-0-2
branch
from
ced8341 to
0d3cbcf
Compare
We have observed some issues that are possibly related to these, and async resume is still not supported in PBL in any case; let's disable this for now to see if it addresses immediate issues.
cfallin
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
LGTM; thanks for working on this!
The "add back DETERMINISTIC_TRACE" commit could be dropped IMHO, unless you'd like to keep it around for further debugging needs; in the absence of that reason I'd prefer to keep the delta between upstream and this in PBL to be zero-ish to make patch-slinging easier :-)
|
I'll remove the deterministic trace patch during the update to 128 which I will be doing later today hopefully |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of https://hg.mozilla.org/releases/mozilla-release/rev/FIREFOX_127_0_2_RELEASE which in the git mirror is 64ddb62