Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request to sign message #570

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

tarmo888
Copy link
Member

@tarmo888 tarmo888 commented Sep 19, 2020

  • adds possibility for user to request other chat user to sign a text/object with 2 clicks, just like chat bots can request it from user.

Following features are also in separate PR #592:

  • makes it possible to copy the signed message from sign message modal view.
  • formats root level of JSON as an unordered list on sign message and signed message modal views, if JSON is nested then shows nested object values like it was showing them before.
  • Request to sign chat message will not show JSON white-space in links anymore (it was difficult to click it and took whole screen room).
  • Message signed by chat message is now clickable, so the user can see the details in more user friendlier signed message modal view.
  • removed using dynamic="" because it will be removed some day by other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant