Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog for next release #361

Merged
merged 7 commits into from
Jan 4, 2023
Merged

Add changelog for next release #361

merged 7 commits into from
Jan 4, 2023

Conversation

t-b
Copy link
Member

@t-b t-b commented Dec 28, 2022 •
edited
Loading

@t-b t-b self-assigned this Dec 28, 2022
@t-b t-b added this to the Version 1.09 milestone Jan 2, 2023
@t-b t-b force-pushed the add-changelog-for-next-release branch 2 times, most recently from cd95916 to 76259e5 Compare January 3, 2023 14:29
@t-b t-b added the wait-for-dependency Depends on other PR or updates label Jan 3, 2023
@t-b t-b assigned Garados007 and MichaelHuth and unassigned t-b Jan 3, 2023
@t-b t-b marked this pull request as ready for review January 3, 2023 14:31
@t-b t-b requested a review from MichaelHuth as a code owner January 3, 2023 14:31
@t-b
Copy link
Member Author

t-b commented Jan 3, 2023

Documentation is deployed at https://docs-staging.byte-physics.de/igor-unit-testing-framework.

Garados007
Garados007 requested changes Jan 3, 2023
View reviewed changes
Copy link
Member

@Garados007 Garados007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The following files have no version number:
    • procedures\unit-testing-tracing-analytics.ipf
    • procedures\unit-testing-tracing-auto.ipf
    • procedures\unit-testing-tracing-tracer.ipf
    • procedures\unit-testing-tracing.ipf
  2. The following files have the old copyright year:
    • License.txt

docu/sphinx/source/changelog.rst Outdated Show resolved Hide resolved
@Garados007
Copy link
Member

Do we want that the test files in tests, internal_dev and docu\examples have a version number as well?

@t-b
Copy link
Member Author

t-b commented Jan 3, 2023

Do we want that the test files in tests, internal_dev and docu\examples have a version number as well?

I don't think so. What do you think?

@Garados007 Garados007 removed their assignment Jan 3, 2023
@Garados007
Copy link
Member

I don't think so. What do you think?

These test files are bound to a specific version of UTF. We can highlight this if we just add the header #pragma version=1.09 in the .ipf files. Updating this in the future is pretty easy as we only need to replace one number with the other:

find . -type f -name '*.ipf' -not -path '*/\.*' -exec sed -i 's/#pragma version=1.09/#pragma version=1.10/' {} +

@t-b t-b force-pushed the add-changelog-for-next-release branch 2 times, most recently from 0b205ee to cb77f7b Compare January 4, 2023 11:26
@t-b t-b assigned Garados007 and unassigned MichaelHuth Jan 4, 2023
@t-b t-b removed the wait-for-dependency Depends on other PR or updates label Jan 4, 2023
@t-b
Copy link
Member Author

t-b commented Jan 4, 2023

We can highlight this if we just add the header #pragma version=1.09 in the .ipf files.

Okay. Done.

@t-b t-b requested a review from Garados007 January 4, 2023 11:27
Garados007
Garados007 requested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@Garados007 Garados007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 1.08 remains:

  • Doxyfile: PROJECT_NUMBER = 1.08
  • create-public-release.sh: newVersion=1.08

internal_dev/TestCaseAssertionCounterCheck.ipf Outdated Show resolved Hide resolved
@t-b t-b force-pushed the add-changelog-for-next-release branch from cb77f7b to f8c5650 Compare January 4, 2023 15:56
@t-b
Add version pragma to all ipf files
d590eb4
@t-b
tests/Tracing.ipf: Adapt to changed line numbers
55191f6 
The previous commit added #pragma version directives to all proedure
files. This broke the tracing tests which reference the exact line
numbers.
@t-b
Add changelog entries for next release
9600bc2
@t-b t-b requested a review from Garados007 January 4, 2023 15:57
Garados007
Garados007 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@Garados007 Garados007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@t-b t-b merged commit 5a1a607 into main Jan 4, 2023
@t-b t-b deleted the add-changelog-for-next-release branch January 4, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garados007 Garados007 Garados007 approved these changes

@MichaelHuth MichaelHuth Awaiting requested review from MichaelHuth MichaelHuth is a code owner

Assignees

@Garados007 Garados007

Labels
None yet
Milestone
Version 1.09
Development

Successfully merging this pull request may close these issues.
3 participants
@t-b @Garados007 @MichaelHuth