Fix/stability #21
Merged
Fix/stability #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is done for the travis-ci.com migration, its further described over here badges/shields#1711. Fixes #7
This change is done for the travis-ci.com migration, its further described over here badges/shields#1711. Fixes #7
…-release-expo into fix/stability
|
Code Climate has analyzed commit dace247 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -21,7 +23,17 @@ const prepare: SemanticMethod = async (config, context) => { | |||
| }) | |||
| )); | |||
|
|
|||
| await Promise.all(writes); | |||
| try { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 96.87% 95.14% -1.73%
===========================================
Files 9 9
Lines 96 103 +7
Branches 15 15
===========================================
+ Hits 93 98 +5
- Misses 3 5 +2
|
This helps making the PR more understandable when fixing multiple issues.
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 96.87% 95.14% -1.73%
===========================================
Files 9 9
Lines 96 103 +7
Branches 15 15
===========================================
+ Hits 93 98 +5
- Misses 3 5 +2
|
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 96.87% 95.14% -1.73%
===========================================
Files 9 9
Lines 96 103 +7
Branches 15 15
===========================================
+ Hits 93 98 +5
- Misses 3 5 +2
|
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 96.87% 95.14% -1.73%
===========================================
Files 9 9
Lines 96 103 +7
Branches 15 15
===========================================
+ Hits 93 98 +5
- Misses 3 5 +2
|
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 96.87% 95.14% -1.73%
===========================================
Files 9 9
Lines 96 103 +7
Branches 15 15
===========================================
+ Hits 93 98 +5
- Misses 3 5 +2
|
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 96.87% 95.14% -1.73%
===========================================
Files 9 9
Lines 96 103 +7
Branches 15 15
===========================================
+ Hits 93 98 +5
- Misses 3 5 +2
|
|
I'm merging this, there is no direct increase in coverage misses. I reformatted the exception throws which results in these increases. |
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 96.87% 95.14% -1.73%
===========================================
Files 9 9
Lines 96 103 +7
Branches 15 15
===========================================
+ Hits 93 98 +5
- Misses 3 5 +2
|
byCedric
pushed a commit
that referenced
this pull request
Jul 11, 2018
# [1.2.0](1.1.1...1.2.0) (2018-07-11) ### Code refactors * increase usability and other minor changes ([#21](#21)) ([49e29b1](49e29b1)), closes [#7](#7) [#7](#7) ### Code style changes * remove extraneous space in log statement ([cdaa1b9](cdaa1b9)) ### New features * inherit configuration from prepare when verifying ([#20](#20)) ([729baeb](729baeb))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 96.87% 95.14% -1.73%
===========================================
Files 9 9
Lines 96 103 +7
Branches 15 15
===========================================
+ Hits 93 98 +5
- Misses 3 5 +2
|
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 96.87% 95.14% -1.73%
===========================================
Files 9 9
Lines 96 103 +7
Branches 15 15
===========================================
+ Hits 93 98 +5
- Misses 3 5 +2
|
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 96.87% 95.14% -1.73%
===========================================
Files 9 9
Lines 96 103 +7
Branches 15 15
===========================================
+ Hits 93 98 +5
- Misses 3 5 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This increases error traceability and contains other documentation fixes.