Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link line number #62

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Fix link line number #62

merged 1 commit into from
Jul 27, 2021

Conversation

saswatamcode
Copy link
Collaborator

This PR fixes issue where link error line number doesn't show in error for links containing special character.

For e.g. links like, https://docs.google.com/drawings/d/e/2PACX-1vTfko27YB_3ab7ZL8ODNG5uCcrpqKxhmqaz3lW-yhGN3_oNxkTrqfXmwwlcZjaWf3cGgAJIM4CMwwkEV/pub?w=960&h=720 show the following error,

README.md:: "https://docs.google.com/drawings/d/e/2PACX-1vTfko27YB_3ab7ZL8ODNG5uCcrpqKxhmqaz3lW-yhGN3_oNxkTrqfXmwwlcZjaWf3cGgAJIM4CMwwkEV/pub?w=960&h=720" not accessible; status code 400: Bad Request

Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode saswatamcode requested a review from bwplotka July 20, 2021 06:38
@saswatamcode saswatamcode self-assigned this Jul 20, 2021
Copy link
Owner

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@bwplotka bwplotka merged commit 95fe9cc into bwplotka:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants