Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor code and add more linters #159

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor code and add more linters #159

wants to merge 5 commits into from

Conversation

ccoVeille
Copy link
Contributor

@ccoVeille ccoVeille commented Apr 1, 2024 •
edited
Loading

  • Catch errors with errors.Is and errors.As
  • Remove useless receivers
  • Avoid types juggling
  • rewrite to use standard lib constants when possible
  • rewrite test to use comply thelper linter

@ccoVeille
Copy link
Contributor Author

@bwplotka is there anything you need to consider reviewing my PR?

@bwplotka
Copy link
Owner

bwplotka commented Jul 3, 2024

Yes @ccoVeille - please rebase and add clear PR title please.

@ccoVeille ccoVeille changed the title please accept my code review refactor code and add more linters Jul 3, 2024
@ccoVeille
Copy link
Contributor Author

Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccoVeille @bwplotka