Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

74 byte handshake #1343

Merged
merged 3 commits into from
Mar 9, 2023
Merged

74 byte handshake #1343

merged 3 commits into from
Mar 9, 2023

Conversation

FedorLap2006
Copy link
Collaborator

Update format of the UDP handshake when performing IP discovery.

+ direction (2 bytes, 1 - send, 2 - recv)
+ length (2 bytes, 70)
  ssrc (4 bytes)
- ip (16 bytes)
+ ip (64 bytes, null terminated)
  port (2 bytes)

@FedorLap2006
feat(voice): 74 byte udp handshake
7564d31 
Update the format of UDP handshake to use 74 byte packets.
@FedorLap2006 FedorLap2006 added feature Major feature implementation high priority Issue or PR with high priority of merge labels Mar 7, 2023
@FedorLap2006 FedorLap2006 added this to the v0.27.1 milestone Mar 7, 2023
@FedorLap2006 FedorLap2006 self-assigned this Mar 7, 2023
@crivasr crivasr mentioned this pull request Mar 8, 2023
Closed
crivasr
crivasr reviewed Mar 8, 2023
View reviewed changes
voice.go Outdated Show resolved Hide resolved
crivasr
crivasr reviewed Mar 8, 2023
View reviewed changes
voice.go Outdated Show resolved Hide resolved
@FedorLap2006
docs: use new positions in comments
e846ff6
@FedorLap2006
feat: document type and length fields
913af34 
Add descriptions of type and length fields to the request packet documentation.
@crivasr
Copy link

crivasr commented Mar 9, 2023

I think that's all we need. The deadline to implement this is march 15th, so the sooner we deploy this the better

@FedorLap2006 FedorLap2006 merged commit ba97131 into master Mar 9, 2023
FedorLap2006 added a commit that referenced this pull request Mar 14, 2023
@FedorLap2006
74 byte handshake (#1343)
9c487a8 
* feat(voice): 74 byte udp handshake

Update the format of UDP handshake to use 74 byte packets.

* docs: use new positions in comments

* feat: document type and length fields

Add descriptions of type and length fields to the request packet documentation.
FedorLap2006 added a commit that referenced this pull request Mar 15, 2023
@FedorLap2006
74 byte handshake (#1343)
213a288 
* feat(voice): 74 byte udp handshake

Update the format of UDP handshake to use 74 byte packets.

* docs: use new positions in comments

* feat: document type and length fields

Add descriptions of type and length fields to the request packet documentation.
FedorLap2006 added a commit that referenced this pull request Mar 15, 2023
@FedorLap2006
74 byte handshake (#1343)
9910ae2 
* feat(voice): 74 byte udp handshake

Update the format of UDP handshake to use 74 byte packets.

* docs: use new positions in comments

* feat: document type and length fields

Add descriptions of type and length fields to the request packet documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crivasr crivasr crivasr left review comments

Assignees

@FedorLap2006 FedorLap2006

Labels
feature Major feature implementation high priority Issue or PR with high priority of merge
Projects
None yet
Milestone
v0.27.1
Development

Successfully merging this pull request may close these issues.
2 participants
@FedorLap2006 @crivasr